Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a set to the AttenuatorBase device #928

Open
noemifrisina opened this issue Nov 27, 2024 · 0 comments
Open

Add a set to the AttenuatorBase device #928

noemifrisina opened this issue Nov 27, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@noemifrisina
Copy link
Collaborator

Spawend from #889

Right now the AttenuatorBase device is only used for reading but there are a couple of PVs that can be set in there (comment reported here):

Either this attenuator is only used for reading and we remove these PVs or we want to add the setting too, in which case AttenuatorBase should have a set.

If we're going to do setting as well I actually think you might be able to get away with exactly the same set between the two. In the i24 case:

_filters_in_position contains only BL24I-OP-ATTN-01:MP1:INPOS and BL24I-OP-ATTN-01:MP2:INPOS
_calculated_filter_states are soft signals that are all high
_change is a soft signal that's a no-op

Acceptance Criteria

  • There is a set in the AttenuatorBase device
@stan-dot stan-dot added the enhancement New feature or request label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants