You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A brief description of the issue:
The mock parameter in the DeviceInitializationController API is only meaningful when connect_immediately=True. Otherwise, it is ignored, and users need to inspect the factory code to determine its behavior. This makes the API confusing and difficult to use, especially in cases requiring clarity on mock handling. There is a related issue in blueapi to be worked on after this
This issue is not beamline-specific but arises from general usage challenges with the API. Addressing it will improve usability and make the API more intuitive for all developers.
Acceptance Criteria
The behavior of the mock parameter is clearly documented, including its dependency on connect_immediately.
Any misleading or unused functionality related to the mock parameter is addressed or renamed for clarity (e.g., mock_if_connect_immediately).
Developers can easily understand how to configure mock without needing to inspect the factory code.
The text was updated successfully, but these errors were encountered:
Regardless of whether the device_factory method changes, the value is still cached on the device factory and requires that blueapi (etc.) has access to it, not just the device- meaning that dodal can't define a "get_all_devices" that just returns unconnected devices, as other services need to know if a device should be connected to a mock backend.
A brief description of the issue:
The mock parameter in the
DeviceInitializationController
API is only meaningful whenconnect_immediately=True
. Otherwise, it is ignored, and users need to inspect the factory code to determine its behavior. This makes the API confusing and difficult to use, especially in cases requiring clarity on mock handling. There is a related issue in blueapi to be worked on after thisThis issue is not beamline-specific but arises from general usage challenges with the API. Addressing it will improve usability and make the API more intuitive for all developers.
Acceptance Criteria
The text was updated successfully, but these errors were encountered: