Update all uncommented commands to remove actions-rs #1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses #1360 by removing references to actions-rs/toolchain and actions-rs/cargo, both of which are unmaintained.
Some parts of the workflows already use dtolnay/rust-toolchain and this is the one most of the community has moved to, so I've changed remaining references to actions-rs/toolchain to dtolnay/rust-toolchain. There's no good replacement for actions-rs/cargo so I've instead moved to just running the commands directly. In cases where Cross is required instead of Cargo to run CI tests, I've added a new action taiki-e/install-action to install Cross and then use a dynamic environment variable to select the correct command to use.
There were a few references to actions-rs that were commented out, I have not touched these.