Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builders #3

Open
ByteAlex opened this issue Apr 6, 2020 · 2 comments
Open

Builders #3

ByteAlex opened this issue Apr 6, 2020 · 2 comments

Comments

@ByteAlex
Copy link
Contributor

ByteAlex commented Apr 6, 2020

For consistency between Discord4J and connect package, the components should be constructed with builders aswell.

@quanticc
Copy link
Member

Can you give us some example to understand and then prioritize?

@ByteAlex
Copy link
Contributor Author

Sure, sorry I thought it would be clear by the name :P

Connect-module initializes a lot of objects still with the "new" keyword as of this example:
new RSocketGlobalRouterServer(routerServerAddress, BucketGlobalRateLimiter.create(), Schedulers.parallel(), RequestQueueFactory.buffering())

D4J's paradigm was to use builders whereever possible, so I opened a ticket to review the connect module and add builders where possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants