-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include link / iframe to application #115
Comments
@schloerke: maybe to revisit with shinylive. |
What a perfect situation! I have some shinylive work time slotted soon. It'd be good to add url encode/decode for r-shinylive. Then the links are dynamically created during build. |
I've drafted something a bit different here with pkgdown: https://github.com/DivadNojnarg/shinylivePkgdown2/blob/main/R/app-container.R and deployed here: https://divadnojnarg.github.io/shinylivePkgdown2/articles/plop.html. All apps are in a folder, the code calls shinylive::export on them, fetch the generated app.json from JS and start shinylive. But what you describe seems more powerful. |
We would need to make a meta cran instance to handle the renv work being done in https://github.com/DivadNojnarg/outstanding-shiny-ui/blob/578f4bab2c4a26ece3aa8bbff17ce0839e81a5a4/.github/workflows/deploy_apps.yaml#L64C1-L67C27 This way when the shinylive apps ask for an app, they are installed from this location as packages are installed at run time. More promising alternative.... Update the website to be artifact deployed (so no commit history is saved as it would bloat quickly), and export all of the shiny apps to be hosted locally. Ex url: This would require that a custom package bundle be using during build time. This is the work I already have prepped to do. This approach has much less moving parts than the meta cran option above. |
Once #114 is merged, apps will always be up to date an hosted. 🎊
I don't know how you'd like to handle it for the online version, but I believe it would be cool to link to the application and/or include an iframe of the app within the page.
code_chunk()
is allowed to return an iframe (and any other markdown output) in addition to the code output.The text was updated successfully, but these errors were encountered: