You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, thanks for the wonderful book.
If you will considering making further changes to the text, I have some suggestions for chapter 4 htmltools-dependencies.Rmd:
4.4 Font Awesome
In part 4.4., the info that icon() provides FA version 5.13.0 is outdated. At time of writing, the current provided version is 6.2.1. This is to be expected, but the following further complicates the points made in the book:
A code snippet with an app to include the new version of the dependency (no matter the current version) would be appreciated. I believe the user should create something like my icon <- function(...)..., which should return a tagList with resolveDependencies(icon_deps)?
I tried to modify the code so that it would instead download the 6.4.2 version of FA, just by changing the references to 5.15.1 in the current code. However, it did not work - I'm not sure if the URLs changed or I did something else wrong.
4.5 Insert Custom script in the head
In the very last code snippet, the config_script function is not used at all, only the options list. An explanation of why this function is needed at all would be welcome. The function itself could also use further clarification, as it stands it is difficult to see what it is meant to do. What does this approach bring as opposed to writing the equivalent code via tags$head(tags$script(...))?
Thank you for your hard work.
The text was updated successfully, but these errors were encountered:
Hi, thanks for the wonderful book.
If you will considering making further changes to the text, I have some suggestions for chapter 4
htmltools-dependencies.Rmd
:4.4 Font Awesome
In part 4.4., the info that
icon()
provides FA version 5.13.0 is outdated. At time of writing, the current provided version is 6.2.1. This is to be expected, but the following further complicates the points made in the book:A code snippet with an app to include the new version of the dependency (no matter the current version) would be appreciated. I believe the user should create something like
my icon <- function(...)
..., which should return a tagList withresolveDependencies(icon_deps)
?I tried to modify the code so that it would instead download the 6.4.2 version of FA, just by changing the references to 5.15.1 in the current code. However, it did not work - I'm not sure if the URLs changed or I did something else wrong.
4.5 Insert Custom script in the head
In the very last code snippet, the
config_script
function is not used at all, only theoptions
list. An explanation of why this function is needed at all would be welcome. The function itself could also use further clarification, as it stands it is difficult to see what it is meant to do. What does this approach bring as opposed to writing the equivalent code viatags$head(tags$script(...))
?Thank you for your hard work.
The text was updated successfully, but these errors were encountered: