Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow nested controllers to override preserveScrollPosition #319

Open
Gaurav0 opened this issue Mar 6, 2023 · 0 comments
Open

Allow nested controllers to override preserveScrollPosition #319

Gaurav0 opened this issue Mar 6, 2023 · 0 comments

Comments

@Gaurav0
Copy link

Gaurav0 commented Mar 6, 2023

Use case:

Only want to apply ember router scroll's default behavior (scroll up on route change) on certain pages of the site.

Possible solution:

set preserveScrollPosition to true on application controller, and false on some pages' controllers.

Problem: This doesn't work with current code:

let preserveScrollPosition =
      (transition.router.currentRouteInfos || []).some(
        (routeInfo) => routeInfo.route.controller.preserveScrollPosition
      ) || this.preserveScrollPosition;

which works out to true if any ancestor controller has preserveScrollPosition set to true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant