Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indended behavior (and execption handling / warning) of repetitive calls to set_ml_nuisance_params #99

Open
MalteKurz opened this issue Apr 12, 2021 · 0 comments

Comments

@MalteKurz
Copy link
Member

  • If the function set_ml_nuisance_params('ml_g', 'd', params) is being called multiple times it results in the last params dict being used.
  • I think this behavior is fine, but I would add a warning for the user whenever the function has been called already with a non-empty dictionary as parameter set.
  • As an alternative "behavior" we could implement that calling set_ml_nuisance_params() does not overwrite already set parameter sets (that also stem from set_ml_nuisance_params() calls) but instead combines them: Add new keys to dict and replace existing ones.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant