Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support for other character encodings #8

Open
DrKain opened this issue Oct 21, 2021 · 1 comment
Open

[Feature Request] Support for other character encodings #8

DrKain opened this issue Oct 21, 2021 · 1 comment
Labels
enhancement New feature or request priotiry: low Low priotity

Comments

@DrKain
Copy link
Owner

DrKain commented Oct 21, 2021

Right now the tool will fail when trying to parse files with this character encoding. For a viable solution the tool should be able to detect the character encoding and convert to UTF-8 when required.
The converted data should be written even if nodes were not modified, this will remove the need to convert a file multiple times when running subclean on an entire library as a scheduled task.

See this #7 (comment) for information on a temporary solution for the current problem.

Unfortunately this will require a dependency like utf8.

Test files:

@DrKain DrKain added enhancement New feature or request priotiry: low Low priotity labels Oct 21, 2021
@DrKain
Copy link
Owner Author

DrKain commented Apr 28, 2022

If you're using Bazarr, you can avoid this issue with the setting:

Settings → Subtitles → Post-Processing → Encode Subtitles To UTF8

@DrKain DrKain changed the title [Feature Request] Support for UCS-2 BE BOM character encoding [Feature Request] Support for other character encodings May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priotiry: low Low priotity
Projects
None yet
Development

No branches or pull requests

1 participant