From 23ab2afadda4c9b6fd83c5190c8b45d1d14d80a5 Mon Sep 17 00:00:00 2001 From: "Staeck, Philipp" Date: Mon, 9 Dec 2024 13:03:58 +0100 Subject: [PATCH] resolve remarks, multiple states may be needed to properly indicate membership in the same ensemble --- src/t2iapi/context/context_requests.proto | 2 +- src/t2iapi/context/service.proto | 27 +++++++++++++++-------- 2 files changed, 19 insertions(+), 10 deletions(-) diff --git a/src/t2iapi/context/context_requests.proto b/src/t2iapi/context/context_requests.proto index cc490ad..94d568c 100644 --- a/src/t2iapi/context/context_requests.proto +++ b/src/t2iapi/context/context_requests.proto @@ -87,6 +87,6 @@ provided ensemble-id. */ message EnsembleIdRequest { string descriptor_handle = 1; - string ensemble_id = 2; // ensemble-id that refers to an SDC PARTICIPANT ENSEMBLE membership shall be indicated in + string ensemble_id = 2; // ensemble-id that refers to the SDC PARTICIPANT ENSEMBLE } diff --git a/src/t2iapi/context/service.proto b/src/t2iapi/context/service.proto index 1f0109f..6871c2d 100644 --- a/src/t2iapi/context/service.proto +++ b/src/t2iapi/context/service.proto @@ -170,19 +170,22 @@ service ContextService { returns (GetEnsembleIdsResponse); /* - Indicate membership in an SDC PARTICIPANT ENSEMBLE for a provided ensemble-id by creating or adapting all needed - pm:EnsembleContextStates such that their @ContextAssociation is "Assoc" and return a list of their @Handles. + Indicate membership in an SDC PARTICIPANT ENSEMBLE for a provided pm:EnsembleContextDescriptor and a provided + ensemble-id by creating or adapting all needed pm:EnsembleContextStates such that their @ContextAssociation is + "Assoc". Return a list that contains only the @Handles of the associated pm:EnsembleContextStates that indicate + membership in the SDC PARTICIPANT ENSEMBLE referred by the provided ensemble-id. The ensemble-id is an identifier specified by the USER that uniquely refers to an SDC PARTICIPANT ENSEMBLE. - To clarify which pm:EnsembleContextStates are needed, three examples are given. + To clarify which pm:EnsembleContextStates are needed and which @Handles shall be returned, four examples are given. Example 1: treatment session The fact that a POC MEDICAL DEVICE is currently working in a (temporal) logical group based on a treatment session - may be expressed by a pm:EnsembleContextDescriptor. If each of its pm:EnsembleContextStates describes a step in - this treatment session, then the manipulation returns only the state handle of the pm:EnsembleContextState with - @ContextAssociation = 'Assoc' that indicates membership in the logical group resp. SDC PARTICIPANT ENSEMBLE. The - provided ensemble-id refers to this logical group resp. SDC PARTICIPANT ENSEMBLE. In this scenario there shall be - only one pm:EnsembleContextState with @ContextAssociation = 'Assoc' at a time for the pm:EnsembleContextDescriptor. + may be expressed by the states of a pm:EnsembleContextDescriptor. If each of its pm:EnsembleContextStates describes + a step in this treatment session, then the manipulation returns only the state handle of the pm:EnsembleContextState + with @ContextAssociation = 'Assoc' that indicates membership in the logical group resp. SDC PARTICIPANT ENSEMBLE. + The provided ensemble-id refers to this logical group resp. SDC PARTICIPANT ENSEMBLE. In this scenario there shall + be only one pm:EnsembleContextState with @ContextAssociation = 'Assoc' at a time for the provided + pm:EnsembleContextDescriptor. Example 2: location inferring If a pm:EnsembleContextDescriptor has multiple pm:EnsembleContextStates whereby each describes a membership of a @@ -196,7 +199,13 @@ service ContextService { modeled by a pm:EnsembleContextDescriptor that has multiple pm:EnsembleContextStates for the major as well as for the minor steps. To indicate membership in a sub process referred by the provided ensemble-id a pm:EnsembleContextState representing a major step and a pm:EnsembleContextState representing a major's minor step - have to be associated. The manipulation shall return the state handles of both pm:EnsembleContextStates. + have to be associated. The manipulation shall return only the state handle of the pm:EnsembleContextState + representing the minor step. + + Example 4: multiple states for one ensemble-id + Consider a scenario where multiple pm:EnsembleContextStates of a provided pm:EnsembleContextDescriptor are needed to + indicate membership in the same SDC PARTICIPANT ENSEMBLE referenced by the given ensemble-id. These states are all + associated at the same time and the manipulation shall return their handles. The state shall be persistent until a next manipulation call. If the device is not able to maintain the static state, it shall return RESULT_NOT_SUPPORTED.