Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look at adding functions from Module::Build::XSUtil #8

Open
wolfsage opened this issue Mar 26, 2014 · 1 comment
Open

Look at adding functions from Module::Build::XSUtil #8

wolfsage opened this issue Mar 26, 2014 · 1 comment

Comments

@wolfsage
Copy link
Collaborator

Module::Build::XSUtil has implemented some missing functionality in Devel::PPPort. Port it in.

https://metacpan.org/source/HIDEAKIO/Module-Build-XSUtil-0.06/lib/Module/Build/XSUtil.pm#L231

@Leont
Copy link
Member

Leont commented Mar 26, 2014

The original is actually from Module::Install::XSUtil, it seems.

It seems __attribute__format__ and newSVpvs_share are already supported. CvGV_set should definitely be supported (given CvGV is no longer an lvalue since 5.recentish). GvNAME_get, GvNAMELEN_get, LIKELY, UNLIKELY and STATIC_INLINE all seem rather reasonable too.

I have no idea what the LooksLikeNumber is about exactly, it must be working around some kind of bug on older releases. It doesn't appear to be actually used though.

newAV_mortal, newHV_mortal, newRV_inc_mortal, newRV_noinc_mortal seem to be innovations of xshelper, though they might be useful enough that backporting to core is an option.

DECL_BOOT and CALL_BOOT are not used anywhere outside of Mouse, I think we can safely ignore those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants