Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove magic strings / references to Duke #15

Open
dleehr opened this issue Jul 18, 2017 · 0 comments
Open

Remove magic strings / references to Duke #15

dleehr opened this issue Jul 18, 2017 · 0 comments

Comments

@dleehr
Copy link
Member

dleehr commented Jul 18, 2017

This program interfaces with a few pieces of infrastructure at Duke: OIDC for OAuth, Grouper for group membership, and Duke Data Service for data.

OIDC and grouper are not Duke-specific, so the code should reflect that it works with these projects/standards (e.g. change the specific dukeUniqueID fields to something like accountID if valid).

Duke Data Service, on the other hand, is the name of that singular project, so it follows that identifiers here relating to that project would follow its name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant