Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed authentication redirects to non-existent named 'login' view #30

Open
dleehr opened this issue Jun 18, 2018 · 1 comment
Open

Comments

@dleehr
Copy link
Member

dleehr commented Jun 18, 2018

Consuming applications may define this view, but gcb-web-auth should only redirect to view names it provides

return redirect('login')

@dleehr
Copy link
Member Author

dleehr commented Jun 18, 2018

I found this when re-deploying dev this morning. The authenticate was returning None because I had removed myself from the group manager group.

But, rather than display an error message about not being in the correct group, it failed through to the redirect('login') call. Took quite a bit of time to figure out what was happening, so if we're going to keep the group manager stuff in place, we should report some errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant