Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add request argument to authenticate methods #52

Open
johnbradley opened this issue Apr 26, 2022 · 0 comments
Open

Add request argument to authenticate methods #52

johnbradley opened this issue Apr 26, 2022 · 0 comments

Comments

@johnbradley
Copy link
Collaborator

Update the backends to accommodate a change in Django:

The authenticate() method of authentication backends will require request as the first positional argument.

https://github.com/django/django/blob/27aa7035f57f0db30b6632e4274e18b430906799/docs/internals/deprecation.txt#L320-L321

Currently with the latest Django all gcb-web-auth backends are skipped due to this missing argument.

Our current authenticate() methods:

def authenticate(self, token):

def authenticate(self, service=None, token_dict=None):

Adding request=None as the first argument to authenticate() fixes this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant