Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests #2

Open
DyfanJones opened this issue Jul 3, 2020 · 4 comments
Open

Unit tests #2

DyfanJones opened this issue Jul 3, 2020 · 4 comments
Labels
bug Something isn't working help wanted Extra attention is needed
Milestone

Comments

@DyfanJones
Copy link
Owner

Design unit tests to improve robustness of package.

@DyfanJones DyfanJones added the bug Something isn't working label Jul 22, 2020
@DyfanJones DyfanJones added the help wanted Extra attention is needed label Aug 22, 2020
@DyfanJones
Copy link
Owner Author

DyfanJones commented Sep 6, 2020

As most classes connect to sagemaker's api mock test are required. From my understanding R has a framework mockery

R6 mockery example: https://github.com/r-lib/mockery/blob/380d81e1439969908a767e484939450b17b1b9ad/tests/testthat/test_stub.R#L197-L230

If this doesn't work then possibly set up a mock class for unit test similar to how this package works: https://github.com/frbl/OnlineSuperLearner/blob/8d36c4ae946690f53c125362c8081d1039ee2947/R/SMG.Mock.R

@DyfanJones
Copy link
Owner Author

Going forwards unit test/mock test will be raised individually testing out specific classes within R6sagemaker. This is to prevent the momentum of the project slowing down. (Apologises for any issues this causes)

@DyfanJones
Copy link
Owner Author

@DyfanJones DyfanJones added this to the Cran-Release milestone Jun 1, 2021
@DyfanJones
Copy link
Owner Author

DyfanJones commented Aug 18, 2021

Split Packages Requiring Unit tests:

  • R6sagemaker.common
  • R6sagemaker.local
  • R6sagemaker.mlcore
  • R6sagemaker.mlframework
  • R6sagemaker.workflow
  • R6sagemaker.debugger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant