Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CSS source maps #63

Open
nddery opened this issue Jun 1, 2017 · 3 comments
Open

Enable CSS source maps #63

nddery opened this issue Jun 1, 2017 · 3 comments
Assignees
Milestone

Comments

@nddery
Copy link
Contributor

nddery commented Jun 1, 2017

Had to remove CSS source maps to fix #61

@nddery nddery self-assigned this Jun 1, 2017
@nddery nddery modified the milestones: v0.3.0, v0.4.0 Aug 24, 2017
@lastobelus
Copy link

How would I use webpack-merge and config/webpack.dev.conf.js to turn source maps back on? I tried:

{
  module: {
    rules: [
      {
        test: /\.s[ac]ss$/,
        use: [
          { loader: 'style-loader' },
          { loader: 'css-loader' , options: { sourceMap: true } },
          { loader: 'sass-loader' , options: { sourceMap: true } }
        ]
      }
    ]
  }
}

but no luck. Temporarily I've just done it by editing the node_module, but an example of how to use webpack-merge correctly would be awesome.

I don't use sections or admin during front end development, so #61 doesn't affect me.

@nddery
Copy link
Contributor Author

nddery commented Oct 13, 2017

Done directly in the shopify-pipeline module this should work. Have you restarted the server after making the changes ?

I'm not aware of any way to re-enable CSS source maps as you need to modify the loader from Shopify-Pipeline itself.

@lastobelus
Copy link

Ah, OK thanks. I was hoping there was a way to do it with custom config. I did get source maps working by editing shopifyi pipeline directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants