Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check whether is_client can be replaced by is_top_level_client #6982

Open
egrimley-arm opened this issue Sep 12, 2024 · 0 comments
Open

Check whether is_client can be replaced by is_top_level_client #6982

egrimley-arm opened this issue Sep 12, 2024 · 0 comments

Comments

@egrimley-arm
Copy link
Contributor

It is currently unclear whether is_client is or should be set for extension libraries as well as top-level clients. The code should be audited to see exactly how that flag is used, and perhaps is_client and is_top_level_client could be merged.

There is an attempt to set is_client in privload_process_imports() but the condition impmod->base == get_dynamorio_dll_start() is never true at that point because the check is inside if (privload_lookup(name) == NULL) and libdynamorio.so is already loaded.

See #6976.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant