Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of target materials #134

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

knakano0524
Copy link
Contributor

This update is to add materials to the geometry, i.e. one target cup, three NMR coils and one ladder. Zulkaida made the modifications, so he could give some more explanations. He and Jay have compiled and executed the modified code fine.

@zulkaidaakbar
Copy link

We tried (compiled and Run) at UVA and it works

@zulkaidaakbar
Copy link

Anyway, I don't know how to "approve" the review/code

@knakano0524
Copy link
Contributor Author

@zulkaidaakbar Please tell Abi and Kun roughly when you want to merge this PR, so that they can make a review in time.

I have slightly modified the code based on our e-mail conversation. So please take a look at the "Files changed" and add comments/reviews if you want to modify further.

@zulkaidaakbar
Copy link

@liuk @knakano0524 @abinashpun No rush, sometime next week is okay for merging this request. This add 3 materials on the target: NMR coils, Target Cup, and Aluminum ladder which hold the cup

@liuk
Copy link
Contributor

liuk commented Mar 31, 2023

@zulkaidaakbar have you run this macro and confirmed it will generate the geometry we are looking for? It seems to me that the empty target cup with NMR coils is generated correctly, but they are all parallel volumes in addition to the existing target material (which is also a cylinder). These two volumes should be in conflict with each other. Could you check it and show some vertex simulation plot to show that we can see all the target structures we are trying to simulate here?

@zulkaidaakbar
Copy link

Target_Geometry
Hi @liuk Here I attach the geometry of the target. We can see clearly from the picture the NMR Coils, target cups (kelF), and the aluminum ladder. Could you please explain more about the vertex simulation to validate the geometry?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants