Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase onto spack v0.23.0 #33

Closed
xylar opened this issue Nov 26, 2024 · 8 comments
Closed

Rebase onto spack v0.23.0 #33

xylar opened this issue Nov 26, 2024 · 8 comments

Comments

@xylar
Copy link
Collaborator

xylar commented Nov 26, 2024

Spack 0.23.0 has been released:
https://github.com/spack/spack/releases/tag/v0.23.0

I have a branch where I did the rebase as best I could:
https://github.com/xylar/spack/tree/rebase-onto-0.23.0
It was messier than usual, in large part because they have added new dependencies on languages like:

depends_on("cxx", type="build") 

This means that the results could be messy and require some fixes.

@xylar
Copy link
Collaborator Author

xylar commented Nov 26, 2024

@ikalash, when would be a good time to force-push my rebase branch to develop and see how things go? Would this week be better than next?

@ikalash
Copy link

ikalash commented Nov 26, 2024

@xylar : yesterday Trilinos in the spack build got broken b/c of some changes to the syntax for specifying a Kokkos option. I just fixed it. Can we wait till the nightly spack build is clean again? Hopefully it will be tonight. I will ping you when it is.

@xylar
Copy link
Collaborator Author

xylar commented Nov 26, 2024

Yep, sounds fine. Keep me posted. I'll cherry-pick your latest commits onto my rebased branch so nothing gets lost.

@ikalash
Copy link

ikalash commented Nov 30, 2024

I haven't forgotten about this. The nightly spack build is still down due to an omega-h + Kokkos issue (sandialabs/Albany#1092 (comment)). I'll let you know when it's resolved. Hopefully next weke.

@xylar
Copy link
Collaborator Author

xylar commented Nov 30, 2024

Thanks for the update. No rush.

@ikalash
Copy link

ikalash commented Dec 3, 2024

It's OK to merge now.

@xylar
Copy link
Collaborator Author

xylar commented Dec 3, 2024

Great, think you for letting me know. I'll double check that nothing has changed and force-push now.

@xylar
Copy link
Collaborator Author

xylar commented Dec 3, 2024

Done!

@xylar xylar closed this as completed Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants