Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PEC-Insulator boundary condition with staggering #5451

Merged
merged 5 commits into from
Nov 14, 2024
Merged

Fix PEC-Insulator boundary condition with staggering #5451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ba7b32e
Add staggering shift when calculating field location
dpgrote Nov 11, 2024
c560a95
Make BC name consistent with the documentation
dpgrote Nov 12, 2024
847c7ea
Change index 2 to WARPX_ZINDEX
dpgrote Nov 12, 2024
0181794
Avoid accessing out of bounds nodal flag in 1D
dpgrote Nov 12, 2024
0641cb3
Update CI benchmarks for test_2d_pec_field_insulator
dpgrote Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Examples/Tests/pec/inputs_test_2d_pec_field_insulator
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ geometry.prob_hi = 1.e-2 3.e-2

# Boundary condition
boundary.field_lo = neumann periodic
boundary.field_hi = PECInsulator periodic
boundary.field_hi = pec_insulator periodic
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an incidental fix, making the name consistent with what is in the documentation.


warpx.serialize_initial_conditions = 1

Expand Down
8 changes: 4 additions & 4 deletions Regression/Checksum/benchmarks_json/test_2d_pec_field_insulator.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
{
"lev=0": {
"Bx": 0.0,
"By": 0.34938851065132936,
"By": 0.33065279639752304,
"Bz": 0.0,
"Ex": 31871402.236828588,
"Ex": 31873416.396984838,
"Ey": 0.0,
"Ez": 104908439.18998256,
"Ez": 99285542.27022335,
"jx": 0.0,
"jy": 0.0,
"jz": 0.0
}
}
}
27 changes: 18 additions & 9 deletions Source/BoundaryConditions/PEC_Insulator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,10 +426,13 @@ PEC_Insulator::ApplyPEC_InsulatortoField (
amrex::ignore_unused(j, k);

amrex::IntVect const iv(AMREX_D_DECL(i, j, k));
amrex::Real const x = (AMREX_SPACEDIM > 1 ? xyzmin_x.x + (iv[0] - lo_x[0])*dx[0] : 0._rt);
amrex::Real const y = (AMREX_SPACEDIM == 3 ? xyzmin_x.y + (iv[1] - lo_x[1])*dx[1] : 0._rt);
amrex::Real const shiftx = (Fx_nodal[0] ? 0._rt : 0.5_rt);
amrex::Real const x = (AMREX_SPACEDIM > 1 ? xyzmin_x.x + (iv[0] - lo_x[0] + shiftx)*dx[0] : 0._rt);
amrex::Real const shifty = (AMREX_SPACEDIM == 3 ? (Fx_nodal[1] ? 0._rt : 0.5_rt) : 0._rt);
amrex::Real const y = (AMREX_SPACEDIM == 3 ? xyzmin_x.y + (iv[1] - lo_x[1] + shifty)*dx[1] : 0._rt);
#if (AMREX_SPACEDIM > 1)
amrex::Real const z = xyzmin_x.z + (iv[WARPX_ZINDEX] - lo_x[WARPX_ZINDEX])*dx[2];
amrex::Real const shiftz = (Fx_nodal[WARPX_ZINDEX] ? 0._rt : 0.5_rt);
amrex::Real const z = xyzmin_x.z + (iv[WARPX_ZINDEX] - lo_x[WARPX_ZINDEX] + shiftz)*dx[2];
#endif

amrex::IntVect is_insulator_lo;
Expand Down Expand Up @@ -471,10 +474,13 @@ PEC_Insulator::ApplyPEC_InsulatortoField (
amrex::ignore_unused(j, k);

amrex::IntVect const iv(AMREX_D_DECL(i, j, k));
amrex::Real const x = (AMREX_SPACEDIM > 1 ? xyzmin_y.x + (iv[0] - lo_y[0])*dx[0] : 0._rt);
amrex::Real const y = (AMREX_SPACEDIM == 3 ? xyzmin_y.y + (iv[1] - lo_y[1])*dx[1] : 0._rt);
amrex::Real const shiftx = (Fy_nodal[0] ? 0._rt : 0.5_rt);
amrex::Real const x = (AMREX_SPACEDIM > 1 ? xyzmin_y.x + (iv[0] - lo_y[0] + shiftx)*dx[0] : 0._rt);
amrex::Real const shifty = (AMREX_SPACEDIM == 3 ? (Fy_nodal[1] ? 0._rt : 0.5_rt) : 0._rt);
amrex::Real const y = (AMREX_SPACEDIM == 3 ? xyzmin_y.y + (iv[1] - lo_y[1] + shifty)*dx[1] : 0._rt);
#if (AMREX_SPACEDIM > 1)
amrex::Real const z = xyzmin_y.z + (iv[WARPX_ZINDEX] - lo_y[WARPX_ZINDEX])*dx[2];
amrex::Real const shiftz = (Fy_nodal[WARPX_ZINDEX] ? 0._rt : 0.5_rt);
amrex::Real const z = xyzmin_y.z + (iv[WARPX_ZINDEX] - lo_y[WARPX_ZINDEX] + shiftz)*dx[2];
dpgrote marked this conversation as resolved.
Show resolved Hide resolved
#endif

amrex::IntVect is_insulator_lo;
Expand Down Expand Up @@ -516,10 +522,13 @@ PEC_Insulator::ApplyPEC_InsulatortoField (
amrex::ignore_unused(j, k);

amrex::IntVect const iv(AMREX_D_DECL(i, j, k));
amrex::Real const x = (AMREX_SPACEDIM > 1 ? xyzmin_z.x + (iv[0] - lo_z[0])*dx[0] : 0._rt);
amrex::Real const y = (AMREX_SPACEDIM == 3 ? xyzmin_z.y + (iv[1] - lo_z[1])*dx[1] : 0._rt);
amrex::Real const shiftx = (Fz_nodal[0] ? 0._rt : 0.5_rt);
amrex::Real const x = (AMREX_SPACEDIM > 1 ? xyzmin_z.x + (iv[0] - lo_z[0] + shiftx)*dx[0] : 0._rt);
amrex::Real const shifty = (AMREX_SPACEDIM == 3 ? (Fz_nodal[1] ? 0._rt : 0.5_rt) : 0._rt);
amrex::Real const y = (AMREX_SPACEDIM == 3 ? xyzmin_z.y + (iv[1] - lo_z[1] + shifty)*dx[1] : 0._rt);
#if (AMREX_SPACEDIM > 1)
amrex::Real const z = xyzmin_z.z + (iv[WARPX_ZINDEX] - lo_z[WARPX_ZINDEX])*dx[2];
amrex::Real const shiftz = (Fz_nodal[WARPX_ZINDEX] ? 0._rt : 0.5_rt);
amrex::Real const z = xyzmin_z.z + (iv[WARPX_ZINDEX] - lo_z[WARPX_ZINDEX] + shiftz)*dx[2];
#endif

amrex::IntVect is_insulator_lo;
Expand Down
Loading