Remove Cajita Halo stored comm #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streeve
force-pushed
the
cajita_halo_comm
branch
from
5f29ca5
to
a27e102
Compare
sslattery
approved these changes
Aug 3, 2023
streeve
force-pushed
the
cajita_halo_comm
branch
from
a27e102
to
2cd76bd
Compare
sslattery
reviewed
Aug 3, 2023
|
retest this please. |
|
@sslattery in this case the comm is identical, so we just needed to add another comparison |
|
Ignoring HIP timeout |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relies on the global grid having created a new cartesian comm (in a shared_ptr) and using that directly, rather than storing a duplicated copy