Added prefix argument to Grid writeTimeStep #742
Conversation
| void writeTimeStep( ExecutionSpace, const int time_step_index, | ||
| const double time, const Array_t& array, | ||
| const bool gather_array = true ) | ||
| void writeTimeStep( ExecutionSpace, const std::string& prefix, |
There was a problem hiding this comment.
We'll want a backwards compatibility wrapper that passes an empty string to this function (that we deprecate)
There was a problem hiding this comment.
I tried to create this (instead of passing an empty string, the deprecated version replicates the previous behavior of creating a prefix based on the array label). However, there's an issue stemming from there already being another version of this function that infers the ExecutionSpace:
When one (like in the test cases) calls writeTimeStep( "grid_cell_field_2d", 302, 3.43, *cell_field ), it should be going to the new, non-deprecated method, but the compiler instead matches it to the templated writeTimeStep( ExecutionSpace, const int...), templating ExecutionSpace to std::string.
I don't know how to fix this; I tried some stuff that would say "template ExecutionSpace to any class but std::string" but couldn't get it to work.
There was a problem hiding this comment.
We'll just need to add an enable_if to restrict that first argument to a valid execution space - we can chat about it Monday
grid/src/Cabana_Grid_BovWriter.hpp
Outdated
| } | ||
|
|
||
| template <class ExecutionSpace, class Array_t> | ||
| [[deprecated( "writeTimeStep now requires a filename prefix" )]] void |
There was a problem hiding this comment.
Looking at this again, I would rather not deprecate and just directly use the array label as the prefix in the variant
|
Messed up my repo; closing this and will create a new pull request |
You can just reopen, |
Grid's BovWriter currently does not allow the user any control over the filename. This change makes it work the same as the HDF5 particle output.