Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More effective holy order land donations (specifically, Teutonic Order, Knights of St. John) #618

Open
zijistark opened this issue Feb 16, 2019 · 0 comments

Comments

@zijistark
Copy link
Member

Currently, the donation of an island to the Knights of St. John or the donation of a duchy to the Teutonic Order are only checked at the end of a few types of CBs and only for that CB's target title. This is fine and all, but it hardly captures the far more plentiful opportunities to get these holy orders landed in the way that they want to be ASAP. We could:

  • Continue using a CB-based approach, but make it ubiquitous:
    1. Mark all attacker realm titles in the CB's on_success in emf_cb_victory and its counterpart emf_cb_holy_victory as prior_realm_title.
    2. In our emf_cb_on_success_posttitle effect, check all new realm counties' de jure duchies for fulfilling the HO land donation preferences. New realm counties aren't marked prior_realm_title. If a duchy qualifies, fire the appropriate events for the HOs to ask for them (see check_holy_order_donation_effect).
    3. Clear all of these temporary flags.
  • Use a pulse to check for qualifying duchies under every potential land donors' realm.
    • If they qualify, fire a slightly differently worded event (the current one refers to "your newfound land") to request the duchy (or island county sometimes for the Knights of St. John) to the top liege asking for the title(s) in question.

The pulse has the advantage of being able to use preference rules when selecting from among multiple qualifying duchies (unless the CB-based approach hits a war wherein several wanted duchies are gained, unlikely), and it doesn't require an all-CBs "hack." I'd honestly suggest both approaches, however.

We could later extend this to the Livonian Brothers of the Sword and the Livonian Order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant