-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hang time override option to external definition #125
Comments
@jedwards4b, @billsacks, any thoughts on this feature request? On the proposed attribute name ( |
I think hang is the wrong word - how about connection_timeout ? |
I do not like timeout because the code does not time out. It prints a warning and keeps trying. |
In general I agree with @jedwards4b on the name, but it looks like the code is using the name hanging_timer. So it seems to me you want something consistent with that, unless you are going to change the name in the code as well. With keeping with hanging_timer, I think hang_warn_time seems the best name I've heard so far. |
I wouldn't feel tied to the name in the code: I think it's more important to come up with a clear name for users. (The code can always be refactored now or later to bring it into sync with the new name.) What about something like
I'm not sure if we need a global option: it seems like the current hard-coded default could suffice. But I don't mind having a global option if others feel it would be valuable. |
Of everything suggested so far, I think |
Summary of Issue:
Currently, there is a global 300 second 'hang' timer which, when exceeded, generates a warning. In some situations, this timer may be too short or too long.
Expected behavior and actual behavior:
Expect to be able to configure hang timeout warning on a per-external basis
Steps to reproduce the problem (should include model description file(s) or link to publi c repository):
Try adding a
hang_warning = 20
to any externals entryWhat is the changeset ID of the code, and the machine you are using:
a48558d
have you modified the code? If so, it must be committed and available for testing:
No
Screen output or log file showing the error message and context:
This feature was requested by @KateFriedman-NOAA
The text was updated successfully, but these errors were encountered: