Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with index access in OpaqueConversion #6

Open
s-trinh opened this issue Oct 13, 2020 · 0 comments
Open

Issue with index access in OpaqueConversion #6

s-trinh opened this issue Oct 13, 2020 · 0 comments

Comments

@s-trinh
Copy link

s-trinh commented Oct 13, 2020

Hi,

I think there are multiple issues in OpaqueConversion.cpp, for instance:

void Base_MatrixXd_fromIntermediate(base::MatrixXd& result, const wrappers::MatrixXd& cppMarshall)
{
/*Add user code for this conversion*/
for(int i = 0; i < cppMarshall.rows; i++)
{
for(int j=0; j < cppMarshall.cols; j++)
{
result(i,j)=cppMarshall.data[j*4+i];
}
}
}

The index calculation looks not correct. There are multiple other locations in the file where j*4+i seems to be used wrongly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant