Yume2kki fixes #3259
Merged
Yume2kki fixes #3259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The map uses a MoveRoute with a jump and SetVehicleLocation for party movement in a tight loop which causes heavy flickering in our Player. This fix does not appear to be completely correct as RPG_RT does not reset the jump flag here but the "damage" is reduced because SetVehicleLocation -1 cannot happen without patching the game. Fix EasyRPG#3254 Co-Authored-By: Viet Dinh <[email protected]>
|
Thank you, I'll test this PR locally later today as well. |
|
I have confirmed locally that the fix works as intended. |
|
Thanks! I'll only remove the debug log then this is good to go. |
The pointer can be reused by a new bitmap and cause wrong animations. For individual tiles the filename is lost. "filename" in bitmap was renamed to "id" and gets now filename+tileid in that case. Fix EasyRPG#3256 Co-Authored-By: Viet Dinh <[email protected]>
fdelapena
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages for description.
Thanks to @Desdaemon for figuring this out.
@Desdaemon I cannot reproduce the cache key issue because I'm on Linux so it likely uses a different allocator.
Though I'm pretty sure my fix works ;).
Please test if this fixes it for you.