Improve debug image size warnings #3260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ghabry
approved these changes
Aug 29, 2024
|
It seems that there miss some external tab. |
|
Oh right. Thanks for noticing. The indent must be tabs not spaces. When you have an editor config plugin this should be applied automatically |
|
i use qt creator for c++ development which doesn't have an editor config plugin built in, my bad! i'll correct it tommorow |
|
should be ok now |
|
Jenkins: test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the sizing warning more lenient for battle animations and adds support for big charsets. Also rearranged the Spec struct to fix some unnecessary padding (thanks clang).