From 505baa9c008fc12d6fdef4e2c98f69eee4e24005 Mon Sep 17 00:00:00 2001 From: Derrick Greyvensteyn Date: Thu, 21 Dec 2023 14:19:12 +0000 Subject: [PATCH] [ONL-7914] Adds focus state for filters (#1798) * [ONL-7914] Focus state for filter popover * Makes use of button element * Updates snapshots * update screenshots * revert package.json * 2.5.3 --- package-lock.json | 4 +- package.json | 2 +- .../ec-currency-filter.spec.js.snap | 40 ++--- .../ec-date-range-filter.spec.js.snap | 60 +++---- .../ec-filter-popover.spec.js.snap | 70 ++++---- .../ec-filter-popover/ec-filter-popover.vue | 41 ++--- ...c-sync-multiple-values-filter.spec.js.snap | 150 +++++++++--------- .../ec-table-filter.spec.js.snap | 150 +++++++++--------- .../ec-table-filter/ec-table-filter.vue | 1 + ...lters-filter-popover--all__chrome.snap.png | Bin 20614 -> 20715 bytes ...ters-filter-popover--all__firefox.snap.png | Bin 20995 -> 21147 bytes 11 files changed, 253 insertions(+), 265 deletions(-) diff --git a/package-lock.json b/package-lock.json index f2fd81823..057088d8d 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@ebury/chameleon-components", - "version": "2.5.2", + "version": "2.5.3", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@ebury/chameleon-components", - "version": "2.5.2", + "version": "2.5.3", "hasInstallScript": true, "license": "MIT", "dependencies": { diff --git a/package.json b/package.json index 00f937d9a..ec40210c4 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@ebury/chameleon-components", - "version": "2.5.2", + "version": "2.5.3", "main": "src/main.js", "sideEffects": false, "author": "Ebury Team (http://labs.ebury.rocks/)", diff --git a/src/components/ec-currency-filter/__snapshots__/ec-currency-filter.spec.js.snap b/src/components/ec-currency-filter/__snapshots__/ec-currency-filter.spec.js.snap index fabcab872..89b23ac39 100644 --- a/src/components/ec-currency-filter/__snapshots__/ec-currency-filter.spec.js.snap +++ b/src/components/ec-currency-filter/__snapshots__/ec-currency-filter.spec.js.snap @@ -12,18 +12,18 @@ exports[`EcCurrencyFilter > should count every selected currency and the amount `; exports[`EcCurrencyFilter > should count every selected currency in numberOfSelectedFilters 1`] = ` -
- + should count every selected currency in numberOfSele xlink:href="#ec-simple-chevron-down" /> -
+ `; exports[`EcCurrencyFilter > should count the amount as 1 in numberOfSelectedFilters 1`] = ` -
- + should count the amount as 1 in numberOfSelectedFilt xlink:href="#ec-simple-chevron-down" /> -
+ `; exports[`EcCurrencyFilter > should disable clear amount button if the amount is empty 1`] = ` @@ -779,18 +779,18 @@ exports[`EcCurrencyFilter > should render correctly 1`] = ` prevent-overflow="false" > -
- + should render correctly 1`] = ` xlink:href="#ec-simple-chevron-down" /> -
+
should render with custom attributes 1`] = ` prevent-overflow="false" > -
- + should render with custom attributes 1`] = ` xlink:href="#ec-simple-chevron-down" /> -
+
should render if no dates are passed in value prop prevent-overflow="false" > -
- + should render if no dates are passed in value prop xlink:href="#ec-simple-chevron-down" /> -
+
should render properly when all the props are given prevent-overflow="false" > -
- + should render properly when all the props are given xlink:href="#ec-simple-chevron-down" /> -
+
should render properly with an error message when t prevent-overflow="false" > -
- + should render properly with an error message when t xlink:href="#ec-simple-chevron-down" /> -
+
should render properly with an error message when t prevent-overflow="false" > -
- + should render properly with an error message when t xlink:href="#ec-simple-chevron-down" /> -
+
should render properly with an error message when t prevent-overflow="false" > -
- + should render properly with an error message when t xlink:href="#ec-simple-chevron-down" /> -
+
should render with custom attributes 1`] = ` prevent-overflow="false" > -
- + should render with custom attributes 1`] = ` xlink:href="#ec-simple-chevron-down" /> -
+
should display number of selected filters if the valu prevent-overflow="false" > -
- + should display number of selected filters if the valu xlink:href="#ec-simple-chevron-down" /> -
+
should not display number of selected filters if the prevent-overflow="false" > -
- + should not display number of selected filters if the xlink:href="#ec-simple-chevron-down" /> -
+
should render correctly the named slot 1`] = ` prevent-overflow="false" > -
- + should render correctly the named slot 1`] = ` xlink:href="#ec-simple-chevron-down" /> -
+
should render properly when isFullHeight is set 1`] = prevent-overflow="false" > -
- + should render properly when isFullHeight is set 1`] = xlink:href="#ec-simple-chevron-down" /> -
+
should render properly when label prop was given 1`] prevent-overflow="false" > -
- + should render properly when label prop was given 1`] xlink:href="#ec-simple-chevron-down" /> -
+
should reset the open status of the popover 1`] = ` prevent-overflow="false" > -
- + should reset the open status of the popover 1`] = ` xlink:href="#ec-simple-chevron-down" /> -
+
should set the open status of the popover 1`] = ` prevent-overflow="false" > -
- + should set the open status of the popover 1`] = ` xlink:href="#ec-simple-chevron-down" /> -
+
-
- + >{{ label }} -
+