Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Environment Wrapper Tests #276

Open
michele-milesi opened this issue May 1, 2024 · 3 comments
Open

Add Environment Wrapper Tests #276

michele-milesi opened this issue May 1, 2024 · 3 comments
Assignees

Comments

@michele-milesi
Copy link
Member

It would be nice to add a test for the environment wrappers we have. Maybe, using the dummy envs, we could do a couple of iterations and check that the obs/action matches those defined by the observation/action space.

@belerico, @DavideTr8: What do you think?

@belerico
Copy link
Member

belerico commented May 2, 2024

LGTM!

@DavideTr8
Copy link
Collaborator

Unittests are never enough

@belerico belerico self-assigned this May 5, 2024
@belerico
Copy link
Member

belerico commented May 6, 2024

We can also test the environments without creating the expensive game underneath them by mocking the game creation and testing everything else

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants