Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit in movement_var #33

Open
samdeoxys1 opened this issue May 6, 2024 · 2 comments
Open

unit in movement_var #33

samdeoxys1 opened this issue May 6, 2024 · 2 comments

Comments

@samdeoxys1
Copy link

I'm a bit confused about the unit in movement_var from estimate_movement_var, as well as the resulting transition matrix using the RandomWalk transition type.

From the code it seems the unit of the returned movement_var is length / second. In make_state_transition, however, the transition probability is computed using the variance given by estinate_movement_var directly, without dividing it by the sampling frequency in the decoding problem. This means if my time bin for the decoded data is 0.1s, I'm still using a degree of smoothing as if my time bin were 1s.

Is this a correct interpretation of what the code is doing? Thanks!

@edeno
Copy link
Contributor

edeno commented May 7, 2024

Yeah, I think that's a bug in that code I should have fixed. I should have converted it to the correct time bin units. In practice in the paper I was going with a value that wasn't estimated, it was set to a reasonable value for replay (which is faster than the actual movement speed). I was just using this for the simulation. But your interpretation is correct.

@samdeoxys1
Copy link
Author

Thanks! I found that sometimes after I converted it to the correct units, using the result from estimate_movement_var would lead to oversmoothing. I guess it would just need some extra tuning like you said.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants