Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss issues about backup #1

Open
lonble opened this issue Dec 23, 2021 · 1 comment
Open

Discuss issues about backup #1

lonble opened this issue Dec 23, 2021 · 1 comment

Comments

@lonble
Copy link

lonble commented Dec 23, 2021

Someone mentioned the issue of file changes during tar while backup. I personally don't have much experience with shell and tmux , so I am sorry that I can't submit the repair code, but I have some ideas about this.
save-all needs time to complete the saving of all data. If sync and tar are executed before the save-all command has finished, inconsistencies will occur. The current processing method may have some problems. The time required for different machines to complete this task may vary greatly, and it is difficult to determine how long sleep is appropriate.
I found that when I execute save-all on the console, it will prompt [Server thread/INFO]: Saved the game when the task finishes. You can check whether the tmux terminal has output this string to determine whether the save has been completed, and then you can execute sync and tar.

@Edenhofer
Copy link
Owner

In general, I dislike these kind of approaches in which it is necessary to wait for a specific message of the server because those messages tend to be different for each flavor of minecraft. However, I of course can not argue that the current situation is ideal. Waiting for a fixed amount of time is far from it. Nevertheless, I think the waiting-approach wins due to its relative simplicity and because it works across different flavors of minecraft.

I'll leave this issue open in case someone has an idea of how to resolve this issue in a more general fashion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants