Link's Awakening-Unable to start the game

[FouzR]

Game reaches point where you can enter your characters name. However, you can't select the save afterwards, cause it isn't created

[Eeems]

Do you know if it's due to #7

[FouzR]

https://ladecadence.net/trastero/listado%20juegos%20gameboy.html
It appears to be an MBC1 game(the non-dx version at least)
Could also be due to some of the test ROM fails?

[Eeems]

Potentially. @calc84maniac any insight?

[FouzR]

I can also confirm, Link's Awakening Dx does work(since that's MBC5)

[calc84maniac]

Seems to be an issue at

remarkable-gameboy/src/vendor/libqboy/z80mbc.cpp

Line 44 in b136f7a

if (!extram_on || !ram_mode) return 0;

and

remarkable-gameboy/src/vendor/libqboy/z80mbc.cpp

Line 78 in b136f7a

if (!extram_on || !ram_mode) return;

These shouldn't be checking ram_mode, which is checked for its actual usage below these.

Edit: Actually, only the second one does the proper check below it, which I suppose should be copied underneath the first one as well.

[Eeems]

This does appear to fix it!

[Eeems]

Although, the save is missing after a reset, but at least you can start the game.