Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused zcashlc_get_memo_as_utf8 #176

Open
daira opened this issue Dec 11, 2024 · 0 comments · Fixed by #183
Open

Remove unused zcashlc_get_memo_as_utf8 #176

daira opened this issue Dec 11, 2024 · 0 comments · Fixed by #183
Labels
C-tech-debt

Comments

@daira
Copy link
Contributor

daira commented Dec 11, 2024

In #136, a fix was made to zcashlc_get_memo but not also to zcashlc_get_memo_as_utf8. The latter is unused in the Swift SDK, so we should remove it.
daira added a commit to daira/zcash-light-client-ffi that referenced this issue Dec 12, 2024
@daira
Remove zcashlc_get_memo_as_utf8. fixes Electric-Coin-Company#176
e7f0434 
Signed-off-by: Daira-Emma Hopwood <[email protected]>
@daira daira mentioned this issue Dec 12, 2024
Merged
daira added a commit to daira/zcash-light-client-ffi that referenced this issue Dec 13, 2024
@daira
Remove zcashlc_get_memo_as_utf8. fixes Electric-Coin-Company#176
c5d1738 
Signed-off-by: Daira-Emma Hopwood <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-tech-debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove zcashlc_get_memo_as_utf8 daira/zcash-light-client-ffi
1 participant
@daira