Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] LimboReconnect not work with new PacketEvents and LimboAPI #172

Open
WhyYum opened this issue Nov 26, 2024 · 3 comments
Open

[BUG] LimboReconnect not work with new PacketEvents and LimboAPI #172

WhyYum opened this issue Nov 26, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@WhyYum
Copy link

WhyYum commented Nov 26, 2024

Describe the bug
After updating PacketEvents plugins to 2.6.0 from 2.4.1-SNAPSHOT (fix for LimboAPI) and LimboAPI to 1.1.24 from 1.1.27 (fix for PacketEvents), LimboReconnect stopped working. Both with old version 1.1.4 and with new version 1.1.7

To Reproduce

Expected behavior

Screenshots
image

Server Info (please complete the following information):
Velocity 3.4.0
PacketEvents 2.6.0
LimboAPI 1.1.27
LimboReconnect 1.1.7

  • /velocity dump link [e.g. https://dump.velocitypowered.com/abcdef.json]

Additional context

[21:12:01 ERROR]: [connected player] WhyYum (/127.0.0.1:19571): exception encountered in net.elytrium.limboapi.server.LimboSessionHandlerImpl@5cccc737
io.netty.handler.codec.EncoderException: java.lang.IllegalArgumentException: Unable to find id for packet of type net.elytrium.limboapi.protocol.packets.s2c.ChangeGameStatePacket in CLIENTBOUND protocol 1.20.2 phase PLAY
        at io.netty.handler.codec.MessageToByteEncoder.write(MessageToByteEncoder.java:125) ~[velocity.jar:3.4.0-SNAPSHOT (git-9cfcfcf2-b451)]
        at io.netty.channel.AbstractChannelHandlerContext.invokeWrite0(AbstractChannelHandlerContext.java:893) ~[velocity.jar:3.4.0-SNAPSHOT (git-9cfcfcf2-b451)]
        at io.netty.channel.AbstractChannelHandlerContext.invokeWrite(AbstractChannelHandlerContext.java:875) ~[velocity.jar:3.4.0-SNAPSHOT (git-9cfcfcf2-b451)]
        at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:984) ~[velocity.jar:3.4.0-SNAPSHOT (git-9cfcfcf2-b451)]
        at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:868) ~[velocity.jar:3.4.0-SNAPSHOT (git-9cfcfcf2-b451)]
        at net.elytrium.limboapi.thirdparty.fastprepare.handler.PreparedPacketEncoder.write(PreparedPacketEncoder.java:89) ~[?:?]
        at io.netty.channel.AbstractChannelHandlerContext.invokeWrite0(AbstractChannelHandlerContext.java:893) ~[velocity.jar:3.4.0-SNAPSHOT (git-9cfcfcf2-b451)]
        at io.netty.channel.AbstractChannelHandlerContext.invokeWrite(AbstractChannelHandlerContext.java:875) ~[velocity.jar:3.4.0-SNAPSHOT (git-9cfcfcf2-b451)]
        at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:984) ~[velocity.jar:3.4.0-SNAPSHOT (git-9cfcfcf2-b451)]
        at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:868) ~[velocity.jar:3.4.0-SNAPSHOT (git-9cfcfcf2-b451)]
        at io.netty.channel.DefaultChannelPipeline.write(DefaultChannelPipeline.java:964) ~[velocity.jar:3.4.0-SNAPSHOT (git-9cfcfcf2-b451)]
        at io.netty.channel.AbstractChannel.write(AbstractChannel.java:300) ~[velocity.jar:3.4.0-SNAPSHOT (git-9cfcfcf2-b451)]
        at com.velocitypowered.proxy.connection.MinecraftConnection.delayedWrite(MinecraftConnection.java:248) ~[velocity.jar:3.4.0-SNAPSHOT (git-9cfcfcf2-b451)]
        at net.elytrium.limboapi.server.LimboPlayerImpl.writePacket(LimboPlayerImpl.java:79) ~[?:?]
        at net.elytrium.limboapi.server.LimboPlayerImpl.setGameMode(LimboPlayerImpl.java:220) ~[?:?]
        at net.elytrium.limboreconnect.handler.ReconnectHandler.onSpawn(ReconnectHandler.java:60) ~[?:?]
        at net.elytrium.limboapi.server.LimboSessionHandlerImpl.onSpawn(LimboSessionHandlerImpl.java:167) ~[?:?]
        at net.elytrium.limboapi.server.LimboImpl.onSpawn(LimboImpl.java:607) ~[?:?]
        at net.elytrium.limboapi.server.LimboImpl.spawnPlayerLocal(LimboImpl.java:458) ~[?:?]
        at net.elytrium.limboapi.server.LimboImpl.lambda$spawnPlayerLocal$18(LimboImpl.java:547) ~[?:?]
        at io.netty.util.concurrent.AbstractEventExecutor.runTask(AbstractEventExecutor.java:173) ~[velocity.jar:3.4.0-SNAPSHOT (git-9cfcfcf2-b451)]
        at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:166) ~[velocity.jar:3.4.0-SNAPSHOT (git-9cfcfcf2-b451)]
        at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:472) ~[velocity.jar:3.4.0-SNAPSHOT (git-9cfcfcf2-b451)]
        at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:405) ~[velocity.jar:3.4.0-SNAPSHOT (git-9cfcfcf2-b451)]
        at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997) ~[velocity.jar:3.4.0-SNAPSHOT (git-9cfcfcf2-b451)]
        at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) ~[velocity.jar:3.4.0-SNAPSHOT (git-9cfcfcf2-b451)]
        at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) ~[velocity.jar:3.4.0-SNAPSHOT (git-9cfcfcf2-b451)]
        at java.base/java.lang.Thread.run(Thread.java:1583) [?:?]
Caused by: java.lang.IllegalArgumentException: Unable to find id for packet of type net.elytrium.limboapi.protocol.packets.s2c.ChangeGameStatePacket in CLIENTBOUND protocol 1.20.2 phase PLAY
        at com.velocitypowered.proxy.protocol.StateRegistry$PacketRegistry$ProtocolRegistry.getPacketId(StateRegistry.java:915) ~[velocity.jar:3.4.0-SNAPSHOT (git-9cfcfcf2-b451)]
        at com.velocitypowered.proxy.protocol.netty.MinecraftEncoder.encode(MinecraftEncoder.java:52) ~[velocity.jar:3.4.0-SNAPSHOT (git-9cfcfcf2-b451)]
        at com.velocitypowered.proxy.protocol.netty.MinecraftEncoder.encode(MinecraftEncoder.java:32) ~[velocity.jar:3.4.0-SNAPSHOT (git-9cfcfcf2-b451)]
        at io.netty.handler.codec.MessageToByteEncoder.write(MessageToByteEncoder.java:107) ~[velocity.jar:3.4.0-SNAPSHOT (git-9cfcfcf2-b451)]
        ... 27 more```
@WhyYum WhyYum added the bug Something isn't working label Nov 26, 2024
@mdxd44
Copy link
Member

mdxd44 commented Nov 27, 2024

have you tried to set compatibility-mode to true in LimboAPI config?

@WhyYum
Copy link
Author

WhyYum commented Nov 27, 2024

have you tried to set compatibility-mode to true in LimboAPI config?

Yes.
save-uncompressed-packets: true
compatibility-mode: true
The error was with both enabled, without compatibility-mode enabled it wouldn't let me into the server because of PacketEvents

@Brickgard
Copy link

This has been the behavior I have seen since as far back as packetevents 2.5.0ish, as mentioned in the OP.
There's been multiple talks about it being fixed, such as with compatibility-mode or through packetevent updates, but unfortunately I have yet to see a combination that makes LimboReconnect function on these recent versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants