Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BucketName rejects valid bucket names #58

Closed
cceckman opened this issue Apr 11, 2022 · 0 comments · Fixed by #67
Closed

BucketName rejects valid bucket names #58

cceckman opened this issue Apr 11, 2022 · 0 comments · Fixed by #67
Labels
bug Something isn't working

Comments

@cceckman
Copy link

Describe the bug

Bucket names may contain periods, but the BucketName type rejects all strings with periods.

This comment correctly links to these requirements for bucket names. Importantly, bucket names may contain dots (.) - as long as the bucket creator has demonstrated control over the domain containing the bucket name, when the bucket name is interpreted as a domain name.

Note that this means a domain name is always a valid domain name until it hits the API layer (i.e. whenever it's in Rust). I might not be able to create the my-gcs-bucket.embark-studios.com - but it's OK for y'all to create it, or for me to read from it (if/when it exists). That is: within my program('s type system), it's a valid BucketName; it may or may not be valid for a particular API call from a particular user.

To Reproduce

#[test]
fn try_bucket() {
  let bn = BucketName::try_from("my-gcs-bucket.embark-studios.com").unwrap();
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant