Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhandled Promise Rejection in #clearReady() #30

Open
tsightler opened this issue Nov 24, 2024 · 0 comments
Open

Unhandled Promise Rejection in #clearReady() #30

tsightler opened this issue Nov 24, 2024 · 0 comments

Comments

@tsightler
Copy link

Hi @Eneris, it's me again!

In the #clearReady() function there is this:

        if (!this.#ready.isResolved) {
            this.#ready.reject(new Error('Client destroyed'))
        }

However, this creates an unhandled rejection which crashes NodeJS. I can't figure out any way that I can reliably catch this as a consumer, other than implementing a global handler, which is not ideal. I can attach a handler to whenReady prior to calling connect, however, this is recreated on the retry, so it only works once and subsequent retries still cause the error.

I think the simple fix is to modify defer to simply catch rejections and log errors, but I'm not sure of your preferred behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant