Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config.yml written without comments #2078

Open
6 tasks done
SlimeDog opened this issue May 3, 2024 · 5 comments
Open
6 tasks done

config.yml written without comments #2078

SlimeDog opened this issue May 3, 2024 · 5 comments
Labels
status:pending Pending acceptance or closure. type:bug Incorrect behavior, not working as intended

Comments

@SlimeDog
Copy link

SlimeDog commented May 3, 2024

WorldEdit Version

7.3.1-6745

WorldGuard Version

7.0.10-2266

Platform Version

Spigot 1.20.6-4142

Confirmations

  • I am using the most recent Minecraft release.
  • I am using a version of WorldEdit compatible with my Minecraft version.
  • I am using a version of WorldGuard compatible with my Minecraft version.
  • I am using the latest or recommended version of my platform software.
  • I am NOT using a hybrid server, e.g. a server that combines Bukkit and Forge. Examples include Arclight, Mohist, and Cardboard.
  • I am NOT using a fork of WorldEdit, such as FastAsyncWorldEdit (FAWE) or AsyncWorldEdit (AWE)

Bug Description

On server start-up, plugins/WorldGuard/config.yml is (re)written without comments at top of file. The comments are contained in the defaults/config.yml file in the JAR. The comments are (re)written on Paper 1.20.6, and on both Paper and Spigot with previous versions of WorldGuard.

Expected Behavior

Rewrite file with comments, regardless of platform.

Reproduction Steps

  1. Update to Spigot 1.20.6
  2. Update to WorldGuard build 2266
  3. Start server
  4. Compare files

Optional WorldGuard-Report

No response

Anything Else?

No response

@SlimeDog SlimeDog added status:pending Pending acceptance or closure. type:bug Incorrect behavior, not working as intended labels May 3, 2024
@wizjany
Copy link
Collaborator

wizjany commented May 3, 2024

i don't think we do anything paper-specific here tbh, only way i can see this happening is if spigot ships a broken snakeyaml lib and paper doesn't somehow.

@SlimeDog
Copy link
Author

SlimeDog commented May 3, 2024

OK, thanks. I'll pursue that line.

@SlimeDog SlimeDog closed this as completed May 3, 2024
@SlimeDog
Copy link
Author

SlimeDog commented May 3, 2024

$ unzip -l paper-1.20.6-36.jar | grep snakeyaml
        0  05-02-2024 11:29   META-INF/libraries/org/yaml/snakeyaml/
        0  05-02-2024 11:29   META-INF/libraries/org/yaml/snakeyaml/2.2/
   334352  05-02-2024 11:29   META-INF/libraries/org/yaml/snakeyaml/2.2/snakeyaml-2.2.jar
$ unzip -l spigot-1.20.6-4142.jar | grep snakeyaml
   334352  05-03-2024 09:06   META-INF/libraries/snakeyaml-2.2.jar

@SlimeDog SlimeDog reopened this May 3, 2024
@aurorasmiles
Copy link
Collaborator

This doesn't seem to be a spigot-specific issue, I get the same behaviour on Paper. When the files are initially created they have comments, after you restart your server once the comments are gone.

@SlimeDog SlimeDog changed the title config.yml written without comments on Spigot config.yml written without comments Jun 9, 2024
@SlimeDog
Copy link
Author

SlimeDog commented Jun 9, 2024

This doesn't seem to be a spigot-specific issue, I get the same behaviour on Paper. When the files are initially created they have comments, after you restart your server once the comments are gone.

Agreed. Paper wasn't available when I originally posted the issue. Changed title to reflect generality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:pending Pending acceptance or closure. type:bug Incorrect behavior, not working as intended
Projects
None yet
Development

No branches or pull requests

3 participants