-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot work with prisma #113
Comments
I am seeing a similar issue. To give more context, what seems to be going on here with this specific error is that prisma is not compatible with the serverless-optimize package. "serverless": "^2.37.0",
"serverless-plugin-optimize": "^4.1.4-rc.1", Edit - Oh I just realized this is the optimize repo not prisma lol. 🤦 |
So here's a list of my prisma versions for help tackling this issue
|
@goncaloneves Just wondering if you're still maintaining this plugin? @diogogvhenriques same question^? I really like how much this little optimize plugin already does for me. I may be able to chip in something to help iron out this specific issue. For me, prisma support is even more important than an optimized build. I'm wondering if there is a workaround we can use to get unblocked for now? Also, I'm curious what it would take to get a patch fix out there for this as the unexpected token error probably isn't localized to just this one package. |
@softmarshmallow I've managed to get it working with a pretty dirty hacky hotfix. I know it appears to make the issue go away for me. The first commit on that branch has the hacky fix, any more commits are just me trying to actually figure out what's wrong instead of just telling bowerify to ignore the file. But, if this helps anyone else narrow down the scope to some bowerify issue then that's a win. https://github.com/Album-Health/serverless-plugin-optimize Super hacky fix: Album-Health@5fa4c2e EDIT - clarification. Prisma and this plugin aren't working because Bowerify doesn't like this prisma file Something in that file is causing Bowerify to hiccup. |
Will try. Thanks ! |
@bmcilw1 Can you publish the package on npm? Dirty but still, this repo is daed. Think we have no option |
@diogogvhenriques Can you please take a look on this? :) 🙏 |
@softmarshmallow getting this same issue |
This does not seem to work prisma/prisma#7180 |
I'm switching to webpack and it works
|
I've had to bend this plugin in a couple of hacky ways to make it work. It is not ready for NPM and I'm not willing to make it npm compatible until I'm able to clean up the patches a bit. You are welcome to use this branch if you need to. You can reference it directly in your Link to my fork: https://github.com/Album-Health/serverless-plugin-optimize Best of luck. |
I have no idea what's in the NPM version, I didn't publish it. If those simple switches allowed prisma to work for you, that's great! I might look into swapping back to the main plugin myself if that's the case. Here's my fork: https://github.com/Album-Health/serverless-plugin-optimize |
@hoangtrieukd you save my life with these. confirm it works with these two line
|
Also did the magic, but for deployment, when setting
|
prisma/prisma#5392 (comment)
The text was updated successfully, but these errors were encountered: