-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Download-CI LLVM #79
Comments
Can you explain the problem since I don't understand why this wouldn't work offhand? |
Yes, right now Enzyme's cmake makes certain assumptions which fail for the LLVM which we would get when using |
What assumptions are being made mistakenly here? From what I follow in the discussion it looks like Rust is not exporting the LLVM Cmake files, which presumably needs to be resolved in upstream rust. Alternatively Enzyme now supports a secondary build system Bazel if CMake is undesirable. Perhaps seeing the error logs would be helpful to understand the issue if you could past them? |
The build fails (or finds a system libLLVM) when the CMake files are missing for Rust's libLLVM. There is some upstream resistance to bundling those files in all contexts in which libLLVM is distributed. I don't follow what all is going on in the 350 kB of CMake script distributed in |
So these files are how the build system learns where files are as well as various variables/functions/etc. Such as So we do need the functionality in those files, not just the library directories. You could probably copy these from some version of LLVM into a separate findLLVM.cmake script that adheres to the assumptions/conventions of rust with the corresponding path to the rust libraries. But at that point it may just be easier to bundle the LLVM cmake files |
Well, in standard mode, precompiled |
Building LLVM from source takes a lot of resources, so we should add support for
download-ci-llvm
in x.pyhttps://rustc-dev-guide.rust-lang.org/building/bootstrapping.html?highlight=download#what-is-a-sysroot
We discussed this previously in a weekly meeting, but without getting to a conclusion.
This is orthogonal to MSVC support.
cc @jedbrown @wsmoses
The text was updated successfully, but these errors were encountered: