Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent player from item drop #173

Open
tsingyayin opened this issue Jul 28, 2024 · 5 comments
Open

Prevent player from item drop #173

tsingyayin opened this issue Jul 28, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@tsingyayin
Copy link

tsingyayin commented Jul 28, 2024

Now the plugin allows players in the game to drop items, which can be used to obtain limited items in the game. For example, they can use many means to transfer items to players in the field who have not joined the game to transfer illegal items.
Can you add a configuration option to prevent players from throwing items from the inventory at any time?

@tsingyayin tsingyayin added the enhancement New feature or request label Jul 28, 2024
@tsingyayin
Copy link
Author

This is very important, which fundamentally shakes the security of the arena

@tsingyayin
Copy link
Author

I tried to fix it. At present, this minor change is in line with my own expectations. I'm not sure if I need to change something else. #174

@Eredrim
Copy link
Owner

Eredrim commented Jul 28, 2024

Hello,
These mechanics are already implemented in the plugin with region protections. In your arena region, you can enable drop protection to prevent (or at the opposite allow) item dropping.
https://github.com/Eredrim/pvparena/blob/master/doc/regions.md#region-protection

@tsingyayin
Copy link
Author

However, players can leave the protected area in various ways. I know that there are flags in the protection that can restrict players from leaving, but at present, the players on my server are very good at sidestepping, and there are various ways to try to avoid these judgments.

Personally, I think it is not impossible to add a config option in the file that directly prevents all items from falling in the FIGHT state.

In a word, my PR has implemented this small part. If you like, you can merge it. It is regarded as adding a new feature.

@Eredrim
Copy link
Owner

Eredrim commented Jul 29, 2024

PVPArena is designed to create PVP/minigames arenas, not PVP worlds. Following this principle, players should not be able to leave the battle area. In addition, leaving the battlefield area is prevent by default in the plugin, so there is no need for specific configuration.

I agree with you, adding a config option is not impossible but it's not the topic. I have to keep consistency in the way that the plugin works and, to date, most of settings about user interactions with their own inventory are in region config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants