Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
classes.yml
fromclasses
toclassitems
, to be consistent with arena config files (we don't have to worry about backwards compatibility, becauseclasses.yml
wasn't working at all before my previous PR, wasn't usable before this PR, and right now it's entirely undocumented anyway)general.useGlobalClasses
, which defaults tofalse
(so, global classes are opt-in)classes.yml
if the file is emptygeneral.useGlobalClasses
is set totrue
,classitems
node can be removed and no longer is automatically populated with the default classes. Nothing changes for classes that haveuseGlobalClasses
set tofalse
(the default). If there are classes inclassitems
anduseGlobalClasses
is set totrue
, players can use both the global classes and the arena classes, with arena classes overwriting global classes in case of name conflictsSome code was refactored. There was code in two methods that parsed class configuration, and they both were trying to do the same thing. One was for
classes.yml
(it wasn't working at all), the other was for arena config. Now instead of them there's one good method used both forclasses.yml
and arena configs. That's why there's more lines removed than added even though I've added a feature.To do in a separate PR: commands for editing global classes