Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scalebar recalculates and resizes several times during a double-tap zoom operation #674

Open
rolson opened this issue Apr 9, 2024 · 2 comments

Comments

@rolson
Copy link
Contributor

rolson commented Apr 9, 2024

Scalebar recalculates and resizes several times during a double-tap zoom operation.

Ideally we would debounce it so that it only updates a max of every .25 seconds (250ms).

scalebar

@rolson
Copy link
Contributor Author

rolson commented Apr 9, 2024

Thanks to @dfeinzimer for pointing out that we did have debounce in the code before. It looks like it was removed because it wasn't rendering "fluidly". It would be good to reinvestigate that. Maybe the duration just needs to be dialed in.

@dfeinzimer
Copy link
Collaborator

Another optimization to look at is whether the onSizeChange modifier here is needed. At a quick look it may not be needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants