Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utility Network Trace: Programmatic starting points review #925

Closed
dfeinzimer opened this issue Oct 23, 2024 · 1 comment
Closed

Utility Network Trace: Programmatic starting points review #925

dfeinzimer opened this issue Oct 23, 2024 · 1 comment

Comments

@dfeinzimer
Copy link
Collaborator

dfeinzimer commented Oct 23, 2024

Review the usability and workflow for programatic starting points. Some potential issues:

  • The component generates graphics, even for programatic points. If the component is closed, those graphics are left on the map.
  • The purpose of the the add new starting points button becomes unclear. See comment here.
  • The mapPoint and screenPoint initializer parameters seemingly could also be removed when using programatic starting points.
@dfeinzimer dfeinzimer changed the title Utility Network Trace: Programatic starting points review Utility Network Trace: Programmatic starting points review Nov 20, 2024
@dfeinzimer
Copy link
Collaborator Author

  • The component generates graphics, even for programatic points. If the component is closed, those graphics are left on the map.

As the user provides the graphics overlay, they are able to call removeAllGraphics when the component is closed.

  • The purpose of the the add new starting points button becomes unclear...
  • The mapPoint and screenPoint initializer parameters seemingly could also be removed when using programatic starting points.

After checking with Kotlin, the interactive ability to add starting points is always present, even if programatic starting points are used. Thus dropping screenPoint but keeping mapPoint (a Point) aligns us more with Kotlin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant