Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort imports #689

Merged
merged 4 commits into from
Apr 17, 2024
Merged

Sort imports #689

merged 4 commits into from
Apr 17, 2024

Conversation

dfeinzimer
Copy link
Collaborator

In response to this feedback, this PR:

  • Opts the Toolkit into the sorted_imports rule
  • Resolves new warnings raised by the new rule

Once #191 is completed, other unsorted inputs should get picked up by the rule and resolved in subsequent PRs.

Related #406

@dfeinzimer dfeinzimer added the enhancement New feature or request label Apr 16, 2024
@dfeinzimer dfeinzimer requested a review from pgruenler April 16, 2024 19:57
@dfeinzimer dfeinzimer self-assigned this Apr 16, 2024
@dfeinzimer dfeinzimer mentioned this pull request Apr 16, 2024
Closed
21 tasks
@dfeinzimer dfeinzimer mentioned this pull request Apr 16, 2024
Merged
@dfeinzimer dfeinzimer requested a review from mhdostal April 17, 2024 17:02
@dfeinzimer dfeinzimer merged commit ce09820 into v.next Apr 17, 2024
@dfeinzimer dfeinzimer deleted the df/sortImports branch April 17, 2024 21:00
@CalebRas CalebRas mentioned this pull request Apr 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgruenler pgruenler pgruenler approved these changes

@mhdostal mhdostal mhdostal approved these changes

Assignees

@dfeinzimer dfeinzimer

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dfeinzimer @mhdostal @pgruenler