Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline: Remove downloaded area and view details #843

Merged
merged 62 commits into from
Sep 13, 2024

Conversation

yo1995
Copy link
Contributor

@yo1995 yo1995 commented Aug 21, 2024

Description

This PR adds 2 features

  • Remove downloaded files for a preplanned map area
    • By swiping the list row to the left, a delete button is revealed. Once tapped, the directory of the preplanned map area is removed from local disk
    • If an area is currently open but is removed, the selectedMap binding will be set to nil so the online web map is used instead
  • View the metadata of a preplanned map area
    • Tapping on the list row will reveal the metadata view, similar to App Store listing
    • Currently it get all the metadata from the downloaded files. In the next on-demand workflow, some metadata will be serialized when the area is downloaded

@yo1995 yo1995 self-assigned this Aug 27, 2024
@yo1995 yo1995 marked this pull request as ready for review August 27, 2024 21:03
@yo1995 yo1995 requested review from des12437, rolson and philium and removed request for rolson August 28, 2024 20:42
@yo1995 yo1995 marked this pull request as draft August 28, 2024 23:07
@yo1995 yo1995 requested a review from philium September 5, 2024 00:07
@yo1995 yo1995 mentioned this pull request Sep 11, 2024
Copy link
Contributor

@des12437 des12437 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. There is a bug where selectedMap is set to nil every time a map area is deleted, but that should be fixed in the PR to improve selection logics right?

@yo1995
Copy link
Contributor Author

yo1995 commented Sep 11, 2024

Thanks for approving! I was hoping #867 can get reviewed first and merged into this branch. Then I'll merge this PR.

@yo1995 yo1995 merged commit 454e07f into OfflineMapAreasView Sep 13, 2024
@yo1995 yo1995 deleted the Ting/RemovalAndDetails branch September 13, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants