-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offline: Remove downloaded area and view details #843
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yo1995
commented
Aug 28, 2024
Sources/ArcGISToolkit/Components/Offline/MetadataDetailView.swift
Outdated
Show resolved
Hide resolved
Sources/ArcGISToolkit/Components/Offline/MetadataDetailView.swift
Outdated
Show resolved
Hide resolved
Sources/ArcGISToolkit/Components/Offline/MetadataDetailView.swift
Outdated
Show resolved
Hide resolved
des12437
reviewed
Aug 28, 2024
Sources/ArcGISToolkit/Components/Offline/PreplannedListItemView.swift
Outdated
Show resolved
Hide resolved
Sources/ArcGISToolkit/Components/Offline/PreplannedMapModel.swift
Outdated
Show resolved
Hide resolved
philium
reviewed
Sep 5, 2024
Sources/ArcGISToolkit/Components/Offline/PreplannedListItemView.swift
Outdated
Show resolved
Hide resolved
Sources/ArcGISToolkit/Components/Offline/PreplannedListItemView.swift
Outdated
Show resolved
Hide resolved
Sources/ArcGISToolkit/Components/Offline/PreplannedMapModel.swift
Outdated
Show resolved
Hide resolved
Sources/ArcGISToolkit/Components/Offline/PreplannedMapModel.swift
Outdated
Show resolved
Hide resolved
philium
approved these changes
Sep 11, 2024
des12437
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. There is a bug where selectedMap
is set to nil
every time a map area is deleted, but that should be fixed in the PR to improve selection logics right?
Thanks for approving! I was hoping #867 can get reviewed first and merged into this branch. Then I'll merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds 2 features
selectedMap
binding will be set tonil
so the online web map is used instead