-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audit css variables for alignment with design tokens #4098
Comments
It would be great to denote via metadata which is global, and which is local to the component, so in the docs we can label or separate the two types. |
Can someone go through this list to determine which CSS variables should not be documented, and then I'll go through and document the rest? We can eventually use the same list to add Adding a |
@alisonailea @macandcheese Do we have clear info/doc on the https://github.com/Esri/calcite-design-tokens/ side to cover this? If so, we can close it. |
I think we will document the component level vars in each component css file as the component are updated. The global ones will be documented as part of the token effort, yes. |
Related token issue for context: #7180. |
Completed via the Design Token efforts we have (done)
At the completion of #7180 we will have
|
Installed and assigned for verification. |
Background
We need to figure out which CSS variables (both global and component scoped) are used in each component. Once we have a list we can determine naming convention trends and do a big rename if necessary before v1 release.
Additionally, none of the global variables are documented on the component doc pages. We need to determine the conventions for documenting them in the component
tsx
files. New jsdoc tag or same as component scoped CSS variables?Desired Outcome
The text was updated successfully, but these errors were encountered: