Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit css variables for alignment with design tokens #4098

Closed
benelan opened this issue Feb 10, 2022 · 8 comments
Closed

Audit css variables for alignment with design tokens #4098

benelan opened this issue Feb 10, 2022 · 8 comments
Assignees
Labels
Calcite (dev) Issues logged by Calcite developers. docs Issues relating to documentation updates only. estimate - 8 Requires input from team, consider smaller steps. p - high Issue should be addressed in the current milestone, impacts component or core functionality spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment.

Comments

@benelan
Copy link
Member

benelan commented Feb 10, 2022

Background

We need to figure out which CSS variables (both global and component scoped) are used in each component. Once we have a list we can determine naming convention trends and do a big rename if necessary before v1 release.

Additionally, none of the global variables are documented on the component doc pages. We need to determine the conventions for documenting them in the component tsx files. New jsdoc tag or same as component scoped CSS variables?

Desired Outcome

  • A list of all of the CSS variables that each component uses.
  • A naming convention for CSS variables
  • A convention for documenting CSS variables
  • A new issue/epic to document the CSS variables once the above points are completed
@benelan benelan added docs Issues relating to documentation updates only. research Issues that require more in-depth research or multiple team members to resolve or make decision. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Feb 10, 2022
@macandcheese
Copy link
Contributor

It would be great to denote via metadata which is global, and which is local to the component, so in the docs we can label or separate the two types.

@benelan
Copy link
Member Author

benelan commented Mar 15, 2022

@benelan
Copy link
Member Author

benelan commented Apr 7, 2022

Can someone go through this list to determine which CSS variables should not be documented, and then I'll go through and document the rest? We can eventually use the same list to add internal to the variables that are not already named correctly. I know everyone is swamped, but this is a high priority for v1, so it would be good to get started soon.

Adding a * next to the ones that shouldn't be documented would work.

@benelan benelan added the Calcite (dev) Issues logged by Calcite developers. label Jan 30, 2023
@jcfranco
Copy link
Member

jcfranco commented Aug 17, 2023

@alisonailea @macandcheese Do we have clear info/doc on the https://github.com/Esri/calcite-design-tokens/ side to cover this? If so, we can close it.

@macandcheese
Copy link
Contributor

I think we will document the component level vars in each component css file as the component are updated. The global ones will be documented as part of the token effort, yes.

@geospatialem geospatialem changed the title Audit css variables for naming conventions and documentation Audit css variables for alignment with design tokens Oct 16, 2023
@geospatialem
Copy link
Member

Related token issue for context: #7180.

@geospatialem geospatialem added p - high Issue should be addressed in the current milestone, impacts component or core functionality estimate - 8 Requires input from team, consider smaller steps. spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. and removed needs triage Planning workflow - pending design/dev review. labels Oct 16, 2023
@geospatialem geospatialem added this to the 2023 November Priorities milestone Oct 16, 2023
@geospatialem geospatialem removed the research Issues that require more in-depth research or multiple team members to resolve or make decision. label Oct 16, 2023
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Nov 20, 2023
@alisonailea alisonailea added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Nov 27, 2023
@geospatialem geospatialem modified the milestones: 2024-01-17 - Jan Main Release, 2024-01-19 - Jan Maintenance Release, 2024-02-27 - Feb Maintenance Release Jan 17, 2024
@alisonailea
Copy link
Contributor

Completed via the Design Token efforts we have (done)

  • A naming convention for CSS variables
  • A convention for documenting CSS variables
  • A new issue/epic to document the CSS variables once the above points are completed

At the completion of #7180 we will have

  • A list of all of the CSS variables that each component uses.

@alisonailea alisonailea added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Feb 5, 2024
Copy link
Contributor

github-actions bot commented Feb 5, 2024

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned alisonailea Feb 5, 2024
@geospatialem geospatialem removed the 3 - installed Issues that have been merged to master branch and are ready for final confirmation. label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Calcite (dev) Issues logged by Calcite developers. docs Issues relating to documentation updates only. estimate - 8 Requires input from team, consider smaller steps. p - high Issue should be addressed in the current milestone, impacts component or core functionality spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment.
Projects
None yet
Development

No branches or pull requests

6 participants