Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit report button not working #1017

Open
skrishn opened this issue Nov 14, 2024 · 3 comments
Open

Submit report button not working #1017

skrishn opened this issue Nov 14, 2024 · 3 comments
Assignees
Labels
1-BUG Something isn't working Reporter 4.x Crowdsource Reporter (new)
Milestone

Comments

@skrishn
Copy link
Collaborator

skrishn commented Nov 14, 2024

User reported submit report button is not working. Here is the app https://oakgis.maps.arcgis.com/apps/instant/reporter/index.html?appid=aafb28a5d2e4490dbfc27727635c3154. This issue is reported prio to the R3 release

@skrishn skrishn added 1-BUG Something isn't working Reporter 4.x Crowdsource Reporter (new) labels Nov 14, 2024
@skrishn
Copy link
Collaborator Author

skrishn commented Nov 14, 2024

Sumits comment on the issue

"This issue is due the way feature form is configured, in this case we don’t have any fields configured in the feature form.
• When the submit button is clicked, we receive an event containing the form’s valid and invalid fields.
• If valid fields are present and this._isSubmitBtnClicked is true, the form is submitted.
• However, for this layer, there are no configured fields for the form, so clicking the submit button doesn’t return any valid fields, resulting in the form not being submitted.
Possible Solution :-
• Remove the condition that checks for the presence of valid fields before submitting the form.
Needs testing in different cases:

  • valid fields configured and user have entered data
  • invalid data enters and submit should not work"

@skrishn
Copy link
Collaborator Author

skrishn commented Nov 14, 2024

@sumitzarkar by removing this check, I'm afraid we're opening for more (unknown) issues. Can we perform the check fields and disable the button when there are no valid fields. For clarity we may need to show a message. Depending on the approach we'll decide if this going for a patch.

@skrishn
Copy link
Collaborator Author

skrishn commented Nov 14, 2024

@sumitzarkar Works when a field is added and hidden with the form. I'll update the user, and we will review this for R1.

@skrishn skrishn added this to the 2025.R01 milestone Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-BUG Something isn't working Reporter 4.x Crowdsource Reporter (new)
Projects
None yet
Development

No branches or pull requests

2 participants