Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Detailed permissions for signs and /sell. #2212

Open
ToonTown0909 opened this issue Oct 13, 2018 · 2 comments · May be fixed by #5976
Open

[Feature Request] Detailed permissions for signs and /sell. #2212

ToonTown0909 opened this issue Oct 13, 2018 · 2 comments · May be fixed by #5976
Labels
status: open to PR Low priority enhancements that anyone is welcome to contribute. type: enhancement Features and feature requests.

Comments

@ToonTown0909
Copy link

ToonTown0909 commented Oct 13, 2018 •
edited
Loading

Hello! I'd like to request more details permissions for /sell command. Currently, the available permissions are essentials.sell, essentials.sell.bulk, and essentials.sell.hand. I propose the following:

essentials.sell.<item id/name>
essentials.sell.*
essentials.sell.bulk.<item id/name>
essentials.sell.bulk.*
essentials.sell.hand.<item id/name>
essentials.sell.hand.*

Additionally, I propose:
essentials.signs.use.sell.<item id/name>
essentials.signs.use.buy.<item id/name>
essentials.signs.use.free.<item id/name>
essentials.signs.use.enchant.enchantment id.max level
essentials.signs.spawnmob.mob name.amount

What prompted this suggestion is that on my server, I have a shop with basic items available at spawn. What I wanted to do is make /sell available for only those items that I allow, via the proposed permissions.

Thank you,
~toontown0909

EDIT: I apologize for the lack of formatting in those last two suggested permissions, for some reason the text disappears when I include the formatting.
@mdcfe
Copy link
Member

mdcfe commented Oct 14, 2018

This should probably be configurable in case people want to keep the existing behaviour, but I'm fully in support of this if someone's willing to implement it in a PR.

@mdcfe mdcfe added type: enhancement Features and feature requests. status: open to PR Low priority enhancements that anyone is welcome to contribute. labels Oct 14, 2018
@ToonTown0909
Copy link
Author

Was going through some of my old stuff and found this. Am wondering if this is still being considered for implementation?

@NicholasJBond NicholasJBond mentioned this issue Nov 25, 2023
Closed
@NicholasJBond NicholasJBond linked a pull request Nov 25, 2024 that will close this issue
Open
3 tasks
NicholasJBond added a commit to NicholasJBond/Essentials that referenced this issue Nov 25, 2024
@NicholasJBond
Fix EssentialsX#2212
1a0d103 
Added per-item-transaction-permissions and enchant-sign-restrictions to config file. When true, it requires users to have specific commands to enchant or to buy and sell. Enchant sign tweaked a bit to make it auto adjust.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: open to PR Low priority enhancements that anyone is welcome to contribute. type: enhancement Features and feature requests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix @2212 NicholasJBond/Essentials
2 participants
@mdcfe @ToonTown0909