Add wildcard support for /delhome #5919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdrianOliva2
force-pushed
the
feature-delete-all-specific-user-homes
branch
from
fee9987
to
ec1f9b1
Compare
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.
Comments skipped due to low confidence (1)
Essentials/src/main/java/com/earth2me/essentials/commands/Commanddelhome.java:69
- The new wildcard functionality for deleting all homes should be covered by tests to ensure it works as expected.
case "*":
JRoy
approved these changes
Nov 24, 2024
JRoy
changed the title
|
Thanks for the pull request! |
Euphillya
added a commit
to Euphillya/Essentials-Folia
that referenced
this pull request
Nov 24, 2024
EssentialsX@a87760d Add wildcard support for /delhome (EssentialsX#5919)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Information
This PR closes #5313.
Details
Proposed feature:
This wildcard deletes all the homes for a specified user.
So instead of having to do
/delhome <user>:<home>every time until all homes are deleted, you can just do/delhome <user>:*And it'll delete all the user homes
Environments tested:
OS: Windows 11
Java version: JDK 17
Demonstration:
Before
After
Command Execution