Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fault on SpritePad spritesets where the first one is a hires sprite #150

Open
godot64 opened this issue Oct 22, 2019 · 10 comments
Open

Fault on SpritePad spritesets where the first one is a hires sprite #150

godot64 opened this issue Oct 22, 2019 · 10 comments
Assignees
Milestone

Comments

@godot64
Copy link

godot64 commented Oct 22, 2019

Spritemate doesn't load SpritePad sets when the first sprite is a hires Sprite (or even all are hires).

@Esshahn
Copy link
Owner

Esshahn commented Oct 22, 2019

Thank you for the bug report, I will investigate. Funny it didn't come up until today.

@Esshahn Esshahn added this to the 1.21 milestone Oct 22, 2019
@Esshahn Esshahn self-assigned this Oct 22, 2019
@godot64
Copy link
Author

godot64 commented Oct 22, 2019 via email

@Esshahn
Copy link
Owner

Esshahn commented Oct 23, 2019

Um welche SpritePad Version handelt es sich? 1.8.x oder 2.x? Da gibt's ja Änderungen im File Format (Animationsdaten). Kannst Du mir eine solche Datei hier anhängen?

@Esshahn
Copy link
Owner

Esshahn commented Oct 29, 2019

I did a test with version 2.0 beta 1 of SpritePad and got no error when importing a spd file with a hires sprite at first position.

To investigate the issue further, I need your help:

  • what SpritePad version are you using?
  • what's the SpritePad export format (1.8 or 2.x)
  • ideally attach the file or have steps to reproduce.

Cheers!

@Esshahn
Copy link
Owner

Esshahn commented Oct 29, 2019

screenshot 2019-10-29 um 10 19 44

screenshot 2019-10-29 um 10 19 52

@godot64
Copy link
Author

godot64 commented Oct 29, 2019 via email

@Esshahn
Copy link
Owner

Esshahn commented Oct 29, 2019

Thank you for the support Arndt!
I think I'm missing the file.

To do a careful investigation, it is important to understand:

  1. if the file was created within SpritePad (and never modified outside - you mentioned it was created in GoDot)

  2. if the issue is only happening with SpritePad >= 2.3 and not in the previous versions.

@godot64
Copy link
Author

godot64 commented Oct 30, 2019 via email

@godot64
Copy link
Author

godot64 commented Oct 30, 2019

This is how it looks like in SpritePad 2.3...
spritepad23
and this is the according data file:

theshort.zip

It's part of Mermaid's hires image "The Short, the Mule and the Ugly" (can be googled)

@Esshahn
Copy link
Owner

Esshahn commented Oct 30, 2019

Hey Arndt, great feedback and valuable information!

Most important for me is that it's not a bug in Spritemate's importer, but a new file format in SpritePad that I haven't implemented yet.

I will look into supporting it, but it has to be pushed back behind other features, mostly animation support. Thank you for the attached file, I have something to work with now.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants